[9] RFR(S): 8061983: [TESTBUG] compiler/whitebox/MakeMethodNotCompilableTest.java fails with "must not be in queue"

Vladimir Kozlov vladimir.kozlov at oracle.com
Fri Oct 24 16:25:50 UTC 2014

Looks good.


On 10/24/14 5:54 AM, Tobias Hartmann wrote:
> Hi,
> please review the following patch.
> Bug: https://bugs.openjdk.java.net/browse/JDK-8061983
> Webrev: http://cr.openjdk.java.net/~thartmann/8061983/webrev.00/
> Problem:
> In the failing case, the test makes a method not OSR compilable and tries to
> trigger an OSR compilation. 'checkNotOsrCompiled' then fails because a (non-OSR)
> compilation is in the compile queue. The test should not assume triggering an
> OSR compilation of a method may not also trigger a non-OSR compilation.
> Solution:
> I added a method checkNotCompiled(boolean isOsr) to either check if the method
> is OSR compiled or to check if it is non-OSR compiled. The method waits for
> background compilation and then checks.
> Testing:
> Failing testcase with different parameters.
> Best,
> Tobias

More information about the hotspot-compiler-dev mailing list