RFR(XXS): 8073624: Fix warning "converting to non-pointer type 'bool' from NULL" in arraycopynode.cpp

Volker Simonis volker.simonis at gmail.com
Mon Feb 23 09:41:37 UTC 2015


can I please have a review and a sponsor for the following tiny patch
which fixes a warning introduced by "JDK-6912521 System.arraycopy
works slower than the simple loop for little lengths":


For the following code in arraycopynode.cpp:

bool ArrayCopyNode::finish_transform(...) {
    if (in(TypeFunc::Control) != ctl) {
      return NULL;

older versions of GCC and maybe other compilers warn about:

/arraycopynode.cpp:458: warning: converting to non-pointer type 'bool' from NULL

The fix is trivial - just return false instead of NULL as this is
already done in several other places in the same function.

It would be nice if t his could be pushed to jdk9/hs-comp as fast as
possible such that it arrives in jdk9/hs together with 6912521.

Thank you and best regards,

More information about the hotspot-compiler-dev mailing list