RFR (S): 8073154: NULL-pointer dereferencing in LIR_OpProfileType::print_instr
filipp.zhinkin at gmail.com
Wed Feb 25 09:42:17 UTC 2015
Igor, thank you for review.
On Wed, Feb 25, 2015 at 11:49 AM, Igor Veresov <igor.veresov at oracle.com> wrote:
> Looks good.
>> On Feb 24, 2015, at 10:56 PM, Filipp Zhinkin <filipp.zhinkin at gmail.com> wrote:
>> Hi all,
>> please review a small fix for 8073154.
>> LIR_OpProfileType's exact_klass is either a valid ciKlass when we know
>> it statically,
>> or a NULL when we don't.
>> Unfortunately, LIR_OpProfileType::print_instr is dereferencing it
>> without a NULL-check.
>> I've decided to print "unknown" exact klass's value in case of NULL to
>> be consistent
>> with ciTypeEntries::print_ciklass. Missed whitespaces were also added.
>> Bug id: https://bugs.openjdk.java.net/browse/JDK-8073154
>> Webrev: http://cr.openjdk.java.net/~fzhinkin/8073154/webrev.00/
>> Testing: executed a test on my linux-x86_64 laptop.
More information about the hotspot-compiler-dev