RFR(S): 8131326: Enable CheckIntrinsics in all types of builds
zoltan.majo at oracle.com
Wed Jul 15 18:04:53 UTC 2015
Thank you, Vladimir, for the review!
On 07/15/2015 05:36 PM, Vladimir Kozlov wrote:
> Looks good.
> On 7/15/15 7:54 AM, Zoltán Majó wrote:
>> please review the following patch for JDK-8131326.
>> Bug: https://bugs.openjdk.java.net/browse/JDK-8131326
>> Problem: The CheckIntrinsics flag added by JDK-8076112 is currently
>> enabled only in debug builds. As a result, users of
>> product builds might easier oversee potential mismatches between
>> VM-level and classfile-level intrinsics.
>> Solution: This enhancement enables the flag in all types of builds
>> (incl. product builds). The check for orphan methods
>> in src/share/vm/classfile/classFileParser.cpp is also controlled by
>> the CheckIntrinsics flag. To limit the impact of
>> that potentially expensive check on our product builds, this
>> enhancment proposes to include the check only in debug builds.
>> Webrev: http://cr.openjdk.java.net/~zmajo/8131326/webrev.00/
>> Testing: JPRT run using the hotspot testset; all tests pass.
>> Thank you and best regards,
More information about the hotspot-compiler-dev