RFR(M): 8130832: Extend the WhiteBox API to provide information about the availability of compiler intrinsics
zoltan.majo at oracle.com
Wed Jul 22 07:59:56 UTC 2015
On 07/21/2015 09:02 PM, John Rose wrote:
> Yes, that will work, and I think it is cleaner than what we had
> before, as well as providing the new required functionality.
> Reviewed; please get a second reviewer.
thank you for the review! I'll ask Vladimir K., maybe he has time to
look at the newest webrev.
> — John
> P.S. If the unit tests want to test (via the whitebox API) whether an
> intrinsic was compiled successfully, we might want to
> expose Compile::gather_intrinsic_statistics, etc. But not in this
> change set.
That is an interesting idea. We'd also have to see if current tests
require such functionality or if SQE plans to add tests requiring that
> P.P.S. As I think I said before, I wish we had a way to consolidate
> the switch statements further (into vmSymbols.hpp). But I don't see a
> clean way to do it.
Yes, that would be nice. I've not seen a good way to do that, partly
because inconsistencies between the way C1 and C2 depends on the value
of command-line flags.
> On Jul 21, 2015, at 8:19 AM, Zoltán Majó <zoltan.majo at oracle.com
> <mailto:zoltan.majo at oracle.com>> wrote:
>> Here is the newest webrev:
>> - top:http://cr.openjdk.java.net/~zmajo/8130832/top/
More information about the hotspot-compiler-dev