RFR (S) 8131782: C1 Class.cast optimization breaks when Class is loaded from static final
john.r.rose at oracle.com
Wed Jul 29 17:53:51 UTC 2015
It's possible that Kris's suggestion helped me (through some unconscious brain backplane) to find the same fix location.
In any case, he called it first; thanks Kris, and keep up the good work!
On Jul 29, 2015, at 2:00 AM, Aleksey Shipilev <aleksey.shipilev at oracle.com> wrote:
> Ah. That would save me half a day digging in HotSpot. Thanks should go
> to John Rose who suggested the factory fix, not the Class.cast intrinsic
> On 07/28/2015 11:43 PM, Krystal Mok wrote:
>> Hi Aleksey,
>> Thanks for fixing this in OpenJDK!
>> I actually noticed the same issue a few weeks ago , but somehow I had
>> missed the reply that Roland sent me, so I didn't send out a request for
>> review for my version of the change.
>> But now that it's fixed, everythings all right ;-)
>> : http://mail.openjdk.java.net/pipermail/hotspot-compiler-dev/2015-June/018179.html
>> On Mon, Jul 27, 2015 at 1:51 AM, Aleksey Shipilev
>> <aleksey.shipilev at oracle.com <mailto:aleksey.shipilev at oracle.com>> wrote:
>> Thanks for pushing the change, Dean!
>> On 07/25/2015 05:32 AM, John Rose wrote:
>>> You are fine.
>>> Aleksey is an Author for JDK 9: http://openjdk.java.net/census#shade
>>> Committers who sponsor changes are expected to use the correct Author
>>> (not themselves).
>>> It's a syntax error to push a non-Author changeset to an OpenJDK repo.
>>> BTW, jcheck does not consult the OJN census AFAIK.
>>> — John
>>> On Jul 24, 2015, at 6:35 PM, Dean Long <dean.long at oracle.com
>> <mailto:dean.long at oracle.com>
>>> <mailto:dean.long at oracle.com <mailto:dean.long at oracle.com>>> wrote:
>>>> OK I will push it now. I did 'hg ci -u shade' so that Aleksey gets
>>>> credit for it, and jcheck isn't complaining. Does anyone know if
>>>> does more checks for Committer status? If so I'll have to redo
>> it and
>>>> add a Contributed-by line.
More information about the hotspot-compiler-dev