RFR(XS): 8132525: java -client -XX:+TieredCompilation -XX:CICompilerCount=1 -version asserts since 8130858
gerard.ziemski at oracle.com
Wed Jul 29 18:50:00 UTC 2015
Right, looks good.
On 07/29/2015 01:48 PM, Roland Westrelin wrote:
> Hi Gerard,
> Thanks for looking at this.
>> You put + // With a client VM, -XX:+TieredCompilation causes TieredCompilation
>> + // to be true here (the option is validated later) and
>> + // min_number_of_compiler_threads to exceed CI_COMPILER_COUNT.
>> + min_number_of_compiler_threads = MIN2(min_number_of_compiler_threads, CI_COMPILER_COUNT);
>> into src/share/vm/runtime/commandLineFlagConstraintsCompiler.cpp file, but that's a constraint function - there should not be any code that sets anything there. Is there somewhere else we can put this code instead of the constraint function?
> min_number_of_compiler_threads is a local variable so it shouldn’t be a problem, right?
>> On 07/29/2015 05:51 AM, Roland Westrelin wrote:
>>> My recent change to the validation of CICompilerCount triggers and assert failure: with -client -XX:+TieredCompilation, TieredCompilation is true when the CICompilerCount option is validated and an erroneous value is used for the min number of threads. TieredCompilation is forced off later in the command line validation process.
More information about the hotspot-compiler-dev