RFR (S) 8134758: Final String field values should be trusted as stable
aleksey.shipilev at oracle.com
Tue Sep 1 16:49:28 UTC 2015
Thanks Vladimir and Tobias, here's a changeset, please sponsor!
On 09/01/2015 07:44 PM, Tobias Hartmann wrote:
> Hi Aleksey,
> that looks good to me.
> On 01.09.2015 18:01, Aleksey Shipilev wrote:
>> On 09/01/2015 06:36 PM, Vladimir Kozlov wrote:
>>> On 9/1/15 4:34 AM, Aleksey Shipilev wrote:
>>>> On 09/01/2015 04:31 AM, Vladimir Kozlov wrote:
>>>>> Why you check constant.basic_type() == T_OBJECT?
>>>>> In old compact strings version it was value field's type but now it is
>>>>> always array.
>>>> Because that line of reasoning got us here: the desynced version that
>>>> gets overlooked for months in Compact String research, and wastes more
>>>> time after the flaw is discovered. I'd prefer to handle all final fields
>>>> in Strings universally, for every possible type, to avoid future
>>> Okay, may be add comment.
>> Sure, I don't see why not:
-------------- next part --------------
A non-text attachment was scrubbed...
Size: 819 bytes
Desc: OpenPGP digital signature
More information about the hotspot-compiler-dev