[aarch64-port-dev ] RFR: 8080293: AARCH64: Remove unnecessary dmbs from generated CAS code

Andrew Dinn adinn at redhat.com
Wed Sep 16 14:04:55 UTC 2015

On 04/09/15 09:59, Andrew Haley wrote:
> On 08/26/2015 10:35 AM, Andrew Dinn wrote:
>> Thanks, Vladimir. So, that is now as provided in the latest posted webrev:
>>   http://cr.openjdk.java.net/~adinn/8080293/webrev.01/
> I'm not happy about the way that all of the code for cmpxchg is
> replicated with only a tiny difference (i.e. an acquiring load).
> It should be super-easy to factor out the common code.

I notice that this refactoring has already been done as part of

  8135157: DMB elimination in AArch64 C2 synchronization implementation

Here is an updated version of my webrev against the latest hs-comp which
adapts to that change:


It is basically the last version minus the definitions for enc_class
aarch64_enc_cmpxchg_acq and enc_class aarch64_enc_cmpxchgw_acq (which
have been provided by 8135157).

Would it be ok to push this now?


Andrew Dinn
Senior Principal Software Engineer
Red Hat UK Ltd
Registered in UK and Wales under Company Registration No. 3798903
Directors: Michael Cunningham (USA), Matt Parson (USA), Charlie Peters
(USA), Michael O'Neill (Ireland)

More information about the hotspot-compiler-dev mailing list