RFR (S) 8147978: Remove Method::_method_data for C1
chris.plummer at oracle.com
Thu Feb 4 17:45:40 UTC 2016
Ok. I can go either way on this particular example. However, when you
start to get a lot of methods using the #ifdefs, it looks cleaner if you
have just one #ifdef/#else/#endif for all of them. For example, see #if
INCLUDE_NMT in memTracker.hpp. So do we want consistency in our approach
to these #ifdefs, or do we want flexibility based on how many #ifdefs
we'll end up with?
On 2/4/16 9:31 AM, Christian Thalinger wrote:
> I’d rather have the #if’s inside the method bodies.
>> On Feb 3, 2016, at 11:20 PM, Chris Plummer <chris.plummer at oracle.com> wrote:
>> Please review the following for removing Method::_method_data when only supporting C1 (or more specifically, when not supporting C2 or JVMCI). This will help reduce dynamic footprint usage for the minimal VM.
>> As part of this fix, ProfileInterperter is forced to false unless C2 or JVMCI is supported. This was mainly done to avoid crashes if it is turned on and Method::_method_data has been excluded, but also because it is not useful except to C2 or JVMCI.
>> Webrev: http://cr.openjdk.java.net/~cjplummer/8147978/webrev.02/
>> Bug: https://bugs.openjdk.java.net/browse/JDK-8147978
>> Test with JPRT -testset hotspot.
More information about the hotspot-compiler-dev