RFR (S) 8147978: Remove Method::_method_data for C1
david.holmes at oracle.com
Fri Feb 5 01:43:54 UTC 2016
On 4/02/2016 5:20 PM, Chris Plummer wrote:
> Please review the following for removing Method::_method_data when only
> supporting C1 (or more specifically, when not supporting C2 or JVMCI).
Does JVMCI exist with C1 only? The COMPILER2_OR_JVMCI conjunction makes
things a bit messy. Can we abstract that behind a single variable,
INCLUDE_METHOD_DATA (or some such) to make it cleaner?
> This will help reduce dynamic footprint usage for the minimal VM.
> As part of this fix, ProfileInterperter is forced to false unless C2 or
> JVMCI is supported. This was mainly done to avoid crashes if it is
> turned on and Method::_method_data has been excluded, but also because
> it is not useful except to C2 or JVMCI.
Are you saying that the information generated by ProfileInterpreter is
only used by C2 and JVMCI? If that is case it should really have been a
C2 only flag.
If ProfileInterpreter is forced to false then shouldn't you also be
checking TraceProfileInterpreter and PrintMethodData use as well
> Webrev: http://cr.openjdk.java.net/~cjplummer/8147978/webrev.02/
> Bug: https://bugs.openjdk.java.net/browse/JDK-8147978
> Test with JPRT -testset hotspot.
More information about the hotspot-compiler-dev