RFR (XXS): 8144621: CompilerControl: inline tests timeout with Xcomp
pavel.punegov at oracle.com
Wed Feb 17 14:39:16 UTC 2016
Thank you for review, Vladimir & Nils.
I filed a new issue to add Xmixed to all tests that need it: https://bugs.openjdk.java.net/browse/JDK-8150054 <https://bugs.openjdk.java.net/browse/JDK-8150054> and going to make a fix soon
> On 16 Feb 2016, at 20:41, Nils Eliasson <nils.eliasson at oracle.com> wrote:
> On 2016-02-15 17:41, Vladimir Kozlov wrote:
>> Should we fix tests with *.* commands instead? Could you, please, list those tests (I want to look)? May be add -Xmixed if they don't like -Xcomp? Or use real method's names instead of *.*?
> +1 on adding -Xmixed to all the compiler control tests. Xcomp doesn't add any value to these tests.
> Otherwise - looks good.
> Thanks for fixing!
> Nils Eliasson
>> On 2/15/16 8:26 AM, Pavel Punegov wrote:
>>> please review this small fix for CompilerControl tests.
>>> Issue: tests that generate commands like "inline *.*" (-XX:CompileCommand or directives) with Xcomp make compilers
>>> forcibly inline everything. This significantly increases execution time leading to timeout.
>>> Fix: don’t generated *.* patterns at all for such tests. It will also makes tests that use PrintAssembly to not fail
>>> with OOME by decreasing of the amount of output.
>>> bug: https://bugs.openjdk.java.net/browse/JDK-8144621
>>> webrev: http://cr.openjdk.java.net/~ppunegov/8144621/webrev.00/
-------------- next part --------------
An HTML attachment was scrubbed...
More information about the hotspot-compiler-dev