RFR(XS) : 8141557 : TestResolvedJavaMethod.java times out after 1000 ms

Christian Thalinger christian.thalinger at oracle.com
Wed Jan 20 00:45:00 UTC 2016

I suppose TestAnnotionation is a typo?

+    @TestAnnotionation(1000L)

Could you change that to value = 1000L?  Just for extra clarity.  Then it looks good.

> On Jan 19, 2016, at 11:06 AM, Igor Ignatyev <igor.ignatyev at oracle.com> wrote:
> http://cr.openjdk.java.net/~iignatyev/8141557/webrev.00/
>> 22 lines changed: 16 ins; 0 del; 6 mod; 
> Hi all,
> Could you please review the fix for 8141557?
> The test uses timeout value of org.junit.Test to test reading annotation via JVMCI. In some cases, e.g. on embedded platforms, debug builds or w/ extra vm flags like -Xcomp, 1000ms isn’t enough for the test to complete, and since jtreg doesn’t apply timeout factor for junit/testng timeouts (CODETOOLS-7901567) the test timeouts despite the fact of increased timeout factor.
> The fix changes the test to use a separate annotation, which doesn’t affect test execution, and remove timeout value (which means no timeout).
> JBS: https://bugs.openjdk.java.net/browse/JDK-8141557
> testing: locally
> Thanks,
> Igor

More information about the hotspot-compiler-dev mailing list