[9] RFR(XS): 8147876: ciTypeFlow::is_dominated_by() writes outside dominated array

Vladimir Ivanov vladimir.x.ivanov at oracle.com
Mon Jan 25 17:02:56 UTC 2016

Looks good.

Best regards,
Vladimir Ivanov

On 1/25/16 12:48 PM, Tobias Hartmann wrote:
> Hi,
> please review the following patch:
> https://bugs.openjdk.java.net/browse/JDK-8147876
> http://cr.openjdk.java.net/~thartmann/8147876/webrev.00/
> ciTypeFlow::is_dominated_by() write outside the 'dominated' array because it's size is too small. The problem is that the number of ciBlocks is not equal to the Blocks used by ciTypeFlow (there is a 1:n relation). Therefore, we should use block_count() instead of _methodBlocks->num_blocks().
> Thanks,
> Tobias

More information about the hotspot-compiler-dev mailing list