RFR(S): 8147645: get_ctrl_no_update() code is wrong

Vladimir Kozlov vladimir.kozlov at oracle.com
Wed Jan 27 19:53:11 UTC 2016

Yes, old_node->add_req(NULL) was very odd. It was from day one and I 
don't get why it was needed. I would understand if it was set_req(0, 
NULL) but that is done by remove_globally_dead_node() later.

Your changes are good. I agree.


On 1/27/16 7:39 AM, Roland Westrelin wrote:
> The intrinsify_fill() code doesn’t mark a replaced control as dead. As suggested in the bug, I added an assert to
> get_ctrl_no_update() so we don’t use a loop as a control by accident. I also dropped
> lazy_replace_proj() which is obsolete AFAICT.
> http://cr.openjdk.java.net/~roland/8147645/webrev.00/
> Roland.

More information about the hotspot-compiler-dev mailing list