Suspicious code in GraphKit::record_profiled_receiver_for_speculation
tobias.hartmann at oracle.com
Thu Jul 7 07:44:56 UTC 2016
On 07.07.2016 09:35, Tobias Hartmann wrote:
> Hi Roland,
> On 07.07.2016 09:32, Roland Westrelin wrote:
>>> Thanks for reporting this issue! The "return n" was introduced by JDK-8031755  and I think it can be removed. I filed JDK-8160942  to investigate.
>> As Radek pointed it's not only the extra return, it's also the
>> assignment to maybe_null in the if that has no effect because a second
>> maybe_null is declared there.
> Right, I missed that. Since you added that code, do you think the assignment to maybe_null in the if can be removed?
Without being too familiar with that code, it seems to me that we may lose "not null" information now because we always assume that n may be NULL. So I think the assignment in the if should be fixed.
More information about the hotspot-compiler-dev