RFR(L): 8161259: Simplify including platform files.
aph at redhat.com
Thu Jul 14 09:20:13 UTC 2016
On 14/07/16 10:17, Lindenmaier, Goetz wrote:
> Hi Andrew,
> thanks for looking at this right away.
>>> Please review this webrev.
>> Mostly looks fine, but I don't like that we can't grep to see where
>> files get included.
> Well, you need to grep for "cpu_header(assembler".
Well, yes, you do, but the point is *you don't know that*. You're
a maintenance programmer, trying to fix a bug.
>> Are we really happy with
>> 40 #define SUB(x) x
>> SUB is a very generic name, and this is some very weird macro hacking.
>> At least we need an explanation in a comment.
> That's a good point, I'll rename it to HSSUB (hotspot submacro).
> It should not be too long because it's used so often on one line.
> // Used to note down several macros without spaces to separate
> // them: For M1=foo and M2=bar, the preprocessor does not
> // understand M1M2, but SUB(M1)M2 will work.
OK, so it's a neat way to concatenate macros.
More information about the hotspot-compiler-dev