RFR(L): 8161259: Simplify including platform files.
goetz.lindenmaier at sap.com
Thu Jul 14 09:59:49 UTC 2016
could you or someone else at Red Hat please do a testbuild of my change?
That would be really helpful.
> -----Original Message-----
> From: Andrew Haley [mailto:aph at redhat.com]
> Sent: Donnerstag, 14. Juli 2016 11:20
> To: Lindenmaier, Goetz <goetz.lindenmaier at sap.com>; hotspot-compiler-
> dev at openjdk.java.net
> Subject: Re: RFR(L): 8161259: Simplify including platform files.
> On 14/07/16 10:17, Lindenmaier, Goetz wrote:
> > Hi Andrew,
> > thanks for looking at this right away.
> >>> Please review this webrev.
> >> Mostly looks fine, but I don't like that we can't grep to see where
> >> files get included.
> > Well, you need to grep for "cpu_header(assembler".
> Well, yes, you do, but the point is *you don't know that*. You're
> a maintenance programmer, trying to fix a bug.
Yes, he has to find that out.
> >> Are we really happy with
> >> 40 #define SUB(x) x
> >> SUB is a very generic name, and this is some very weird macro hacking.
> >> At least we need an explanation in a comment.
> > That's a good point, I'll rename it to HSSUB (hotspot submacro).
> > It should not be too long because it's used so often on one line.
> > Comment:
> > // Used to note down several macros without spaces to separate
> > // them: For M1=foo and M2=bar, the preprocessor does not
> > // understand M1M2, but SUB(M1)M2 will work.
> OK, so it's a neat way to concatenate macros.
More information about the hotspot-compiler-dev