RFR (M) 8155739: [TESTBUG] VarHandles/Unsafe tests for weakCAS should allow spurious failures
volker.simonis at gmail.com
Mon May 2 14:34:56 UTC 2016
thanks for this quick fix. The change looks good!
Adding to Paul, you could restrict the definition of WEAK_ATTEMPTS
even further if you want:
static final int WEAK_ATTEMPTS = Integer.getInteger("weakAttempts", 10);
We still have two other test failures with our new intrinsic
implementation on ppc64, but that's pretty sure our fault :)
On Sat, Apr 30, 2016 at 1:42 AM, Paul Sandoz <paul.sandoz at oracle.com> wrote:
>> On 29 Apr 2016, at 15:12, Aleksey Shipilev <aleksey.shipilev at oracle.com> wrote:
>> I would like to fix a simple testbug in our weakCompareAndSet VarHandles
>> and Unsafe intrinsics tests. weakCompareAndSet is spec-ed to allow
>> spurious failures, but current tests do not allow that. This blocks
>> development and testing on non-x86 platforms.
> Looks good.
> Small tweak if you so wish to do so:
> static final int WEAK_ATTEMPTS = Integer.getInteger("weakAttempts", 10);
> which avoids changes to the SunMiscUnsafe* tests.
>> The tests are auto-generated, and the substantiative changes are in
>> *.template files. I also removed obsolete generate-unsafe-tests.sh. I
>> would like to push through hs-comp to expose this to Power and AArch64
>> folks early.
>> Testing: x86_64, jdk:java/lang/invoke/VarHandle, hotspot:compiler/unsafe
More information about the hotspot-compiler-dev