RFR(M): : Various minor code improvements (compiler)
tobias.hartmann at oracle.com
Mon May 9 07:36:32 UTC 2016
On 06.05.2016 10:01, Lindenmaier, Goetz wrote:
> Please review this change. I please need a sponsor.
This looks good to me. Thanks for the detailed explanation, please see some minor suggestions below.
I can sponsor your fix but since we are close to JDK 9 FC, we are not allowed to push enhancements to hs-comp. Shouldn't this be a "bug" anyway?
> - Buffer not null terminated
> - size of pointer passed to jio_snprintf()
Please also fix the indentation in line 6004.
> - jio_snprintf does null termination. But it might return -1 if truncated,
> in this case array access at -1.
You can remove "int n;"
> - Remaining fields not initialized.
I would put the loop bodies in a new line.
> - delta might be -4 ... assert returns.
I don't understand this change. If delta is -4, the assert in the baseline version is triggered. With your fix, the assert is triggered as well.
More information about the hotspot-compiler-dev