RFR(M): : Various minor code improvements (compiler)
goetz.lindenmaier at sap.com
Mon May 9 08:30:40 UTC 2016
> I can sponsor your fix but since we are close to JDK 9 FC, we are not allowed
> to push enhancements to hs-comp. Shouldn't this be a "bug" anyway?
Thanks for reviewing and the offer to sponsor!
I changed the Jira issue to bug. Sorry for being that close to FC with my RFR.
> > - size of pointer passed to jio_snprintf()
> Please also fix the indentation in line 6004.
> > classLoader.cpp
> > - jio_snprintf does null termination. But it might return -1 if truncated,
> > in this case array access at -1.
> You can remove "int n;"
> > generateOopMap.cpp
> > - Remaining fields not initialized.
> I would put the loop bodies in a new line.
> > relocator.cpp
> > - delta might be -4 ... assert returns.
> I don't understand this change. If delta is -4, the assert in the baseline version
> is triggered. With your fix, the assert is triggered as well.
Sorry, that's a bad comment. I meant that the assert does not
protect against getting -4 in that line, because coverity knows
about -XX:SuppressErrorAt. But that's pointless, as assert goes
away in product builds anyways.
The assert shall be triggered, therefore I moved it out of the if().
But the if() now protects against oob with -4 or smaller.
I also rebased the change, and added you as reviewer. Find the new
And the incremental patch:
More information about the hotspot-compiler-dev