RFR (S): 8150247: CompilerControl: LogCompilation testing
vladimir.kozlov at oracle.com
Mon May 9 21:06:39 UTC 2016
Looks good. Thank you for fixing this.
On 5/6/16 12:35 PM, Pavel Punegov wrote:
> I have updated webrev to add @module to jtreg header
> — Pavel.
>> On 05 May 2016, at 21:06, Pavel Punegov <pavel.punegov at oracle.com
>> <mailto:pavel.punegov at oracle.com>> wrote:
>> please review the following change to CompilerControl tests. It adds a
>> new test to cover the gap found by JDK-8145345 [*].
>> The LogCompilation was empty after CompilerControl was integrated, but
>> tests haven’t found that. This happened only when the LogCompilation
>> was specified while there were no directives/CompileCommands enabled.
>> With enabled directive/command it worked fine.
>> Tests didn’t found the issue due to:
>> 1. There were no standalone test for LogCompilation. All related tests
>> enable appropriate log directive or command.
>> 2. LogProcessor incorrectly worked for empty tasks that should be
>> logged. It didn’t reported the issue.
>> [*] https://bugs.openjdk.java.net/browse/JDK-8145345
>> bug: https://bugs.openjdk.java.net/browse/JDK-8150247
>> webrev: http://cr.openjdk.java.net/~ppunegov/8150247/webrev.00/
More information about the hotspot-compiler-dev