RFR(XXS) : 8158185 : jdk/test/lib/FileInstaller throws NPE if dst is in current directory
igor.ignatyev at oracle.com
Tue May 31 13:29:59 UTC 2016
1st of all, thank you for reviewing all these changes!
regarding testing, I run all changed tests locally on mac and run all hotspot/compiler tests remotely on all supported platforms in fastdebug, product variant w/ Xcomp,Xmixed.
this particular fix was tested as a part of JDK-8158184 testing.
> On May 31, 2016, at 5:14 AM, Vladimir Kozlov <vladimir.kozlov at oracle.com> wrote:
> Looks good.
> Igor, how are you testing all these tests fixes?
> On 5/30/16 5:08 PM, Igor Ignatyev wrote:
>>> 2 lines changed: 0 ins; 0 del; 2 mod;
>> Hi all,
>> could you please review this small changeset which fixes FileInstaller? FileInstaller throws NPE if 2nd argument (dst) is in current directory, this happens because Path::getParent returns null if Path doesn’t have a parent. to prevent this, I added Path::toAbsolutePath call.
>> JBS: https://bugs.openjdk.java.net/browse/JDK-8158185
>> webrev: http://cr.openjdk.java.net/~iignatyev/8158185/webrev.00/
>> — Igor
More information about the hotspot-compiler-dev