[9] RFR(S): 8161085: PreserveFPRegistersTest fails with 'AssertionError: Final value has changed'

Vladimir Ivanov vladimir.x.ivanov at oracle.com
Wed Sep 21 10:07:43 UTC 2016

Looks good.

Best regards,
Vladimir Ivanov

On 9/21/16 10:01 AM, Tobias Hartmann wrote:
> Hi,
> please review the following patch:
> https://bugs.openjdk.java.net/browse/JDK-8161085
> http://cr.openjdk.java.net/~thartmann/8161085/webrev.00/
> This problem is very similar to JDK-8148175, the test fails because G1 barriers emitted by C1 do not preserve floating point registers on SPARC. The problem is that the barrier code calls into the runtime without saving/restoring the FP registers. I fixed this by using save_live_registers() instead of manually saving individual registers.
> Tested with failing regression test on SPARC and RBT (running).
> Thanks,
> Tobias

More information about the hotspot-compiler-dev mailing list