RFR: 8016470: AllocatePrefetchDistance is not changed by command line
rahul.v.raghavan at oracle.com
Fri Jun 16 17:27:17 UTC 2017
Thank you Vladimir for review comments.
Based on all comments, made changes to prefetch-allocation related code.
Please review revised <webrev.04> -
Confirmed no issues with jprt (-testset hotspot) testing.
> -----Original Message-----
> From: Vladimir Kozlov
> Sent: Thursday, June 08, 2017 11:53 PM
> To: hotspot-compiler-dev at openjdk.java.net
> Subject: Re:  RFR: 8016470: AllocatePrefetchDistance is not changed by command line
> Hi Rahul
> We usually don't check/set flags in .hpp file. methods there should return values specific for hardware. And only callers in
> vm_version_*.cpp have to use these *default* values depending on
> FLAG_IS_DEFAULT or other conditions.
> Yes, it was mess before but this changes should clean the mess. For example, we don't need allocate_prefetch_style() method - it
> does not check any CPU features.
> On 6/8/17 8:35 AM, Rahul Raghavan wrote:
> > Hi,
> >> -----Original Message-----
> >> From: Tobias Hartmann
> >> Hi Rahul,
> >> On 08.06.2017 12:15, Rahul Raghavan wrote:
> >>> http://cr.openjdk.java.net/~rraghavan/8016470/webrev.01/
> >> Looks good but please also use FLAG_SET_DEFAULT on ARM.
> > Oops, sorry I missed it.
> > Now changes done and I will push this version -
> > http://cr.openjdk.java.net/~rraghavan/8016470/webrev.02/
> > Thank you Tobias for review.
> >> Best regards,
> >> Tobias
> > Thanks,
> > Rahul
More information about the hotspot-compiler-dev