RFR: 8189176 - AARCH64: Improve _updateBytesCRC32 intrinsic
dmitry.chuyko at bell-sw.com
Wed Nov 1 16:24:55 UTC 2017
As per Derek's suggestion I made private
MacroAssembler::kernel_crc32_using_crc32(). Register naming became more
clear, numeric results are the same.
On 10/28/2017 10:52 AM, Andrew Haley wrote:
> On 27/10/17 23:31, White, Derek wrote:
>> - The use of temp registers in the UseCRC32 case is kind of muddled, using tmp, and table0..table3 as temp registers, and the name "table" is confusing in this case.
>> - Maybe it would be cleaner to refactor the UseCRC32 code into a separate kernel_crc32_using_crc32() subroutine (static or macro?). This would accept the main args and 4 registers for temps. The caller can supply some combination of table or tmp registers.
>> - This would shrink the size of kernel_crc32() by a lot too.
> That would be nice.
More information about the hotspot-compiler-dev