RFR: 8192821 : Make LogCompilation into a maven project
eric.caspole at oracle.com
Thu Nov 30 19:14:16 UTC 2017
On 11/30/2017 01:08 PM, Vladimir Kozlov wrote:
> Thank you, Eric
> Can you still keep ability to build with Makefile?
New one: http://cr.openjdk.java.net/~ecaspole/JDK-8192821/02/webrev/
Yes now 'make' still works. Also I added a step in the maven build to
copy the artifact to the top as logc.jar, so now whether you build with
maven or make you will get a logc.jar at the top as it has always
worked, that are functionally the same.
> Please, update README with how to build with Maven.
Also I forgot to say earlier I made slight changes to modernize the
javadoc markup in LogParser.java so the javadoc builds in maven.
Is this OK for 10?
> On 11/30/17 9:57 AM, Eric Caspole wrote:
>> Hi everyone, please review this change to build the LogCompilation
>> tool with Maven rather than a Makefile, so it can easily be imported
>> and used with IDEs. This will allow in future for test cases etc and
>> help prevent bit rot in this useful tool.
>> JBS: https://bugs.openjdk.java.net/browse/JDK-8192821
>> webrev: http://cr.openjdk.java.net/~ecaspole/JDK-8192821/webrev/
More information about the hotspot-compiler-dev