RFR(M): 8200303: C2 should leverage profiling for lookupswitch/tableswitch

Roland Westrelin rwestrel at redhat.com
Wed Apr 4 15:44:56 UTC 2018

Hi Tobias,

Thanks for reviewing this.

> machnode.hpp
> - Do we need a forward declaration of MachJumpNode at the beginning of the header file (like we do
> have for the other MachNodes)?

Not sure why those are there but I don't see a need for one for

> - I think you also need to define MachJumpNode in vmStructs.cpp

Right. I noticed the SA has a MachIfNode class so I suppose it need a
MachJumNode class too. I need to take a closer look.

> parse2.cpp
> - I would prefer "always/never taken" over "taken always/never"

I re-used the text from Parse::adjust_map_after_if().

> - 1160: what is 'ifff' used for?

The ifff is not something new. I changed the arguments that
jump_if_fork_int() takes so had to adjust that line of code.


More information about the hotspot-compiler-dev mailing list