RFR(M): 8200303: C2 should leverage profiling for lookupswitch/tableswitch

Tobias Hartmann tobias.hartmann at oracle.com
Thu Apr 5 09:25:32 UTC 2018

Hi Roland,

On 04.04.2018 17:44, Roland Westrelin wrote:
>> machnode.hpp
>> - Do we need a forward declaration of MachJumpNode at the beginning of the header file (like we do
>> have for the other MachNodes)?
> Not sure why those are there but I don't see a need for one for
> MachJumpNode.

Okay, thanks for checking.

>> parse2.cpp
>> - I would prefer "always/never taken" over "taken always/never"
> I re-used the text from Parse::adjust_map_after_if().

Okay, fine then.
>> - 1160: what is 'ifff' used for?
> The ifff is not something new. I changed the arguments that
> jump_if_fork_int() takes so had to adjust that line of code.

Right, my bad.

I'll re-submit testing now that JDK-8058192 was fixed.

Best regards,

More information about the hotspot-compiler-dev mailing list