RFR(M): 8200303: C2 should leverage profiling for lookupswitch/tableswitch

Tobias Hartmann tobias.hartmann at oracle.com
Thu Apr 5 12:02:16 UTC 2018

Hi Roland,

On 05.04.2018 11:54, Roland Westrelin wrote:
> http://cr.openjdk.java.net/~roland/8200303/webrev.02/

Looks good to me. So far, testing looks good as well.

> I fixed the typo and added MachJump to vmstructs.
> I don't understand how the MachIfNode class in the SA is supposed to be
> used. I tried dumping a graph that has a MachIfNode from clhsdb and the
> MachIfNode shows up as unknown:
>  7      UnknownNode<0x00007fe79787c428> ===  9  8    [[ 6  28 ]]
>  28     IfFalse ===  7  [[ 27 ]]
> So I'm not sure it's worth the trouble of adding a MachJumpNode.
I agree. If so, we should fix this altogether (i.e. for existing nodes as well) but I'm not sure if
anyone is using graph dumping via the SA.

Best regards,

More information about the hotspot-compiler-dev mailing list