RFR: 8215206: VtableStubs::find_stub is not appropriately protected by VtableStubs_lock
per.liden at oracle.com
Tue Dec 11 11:41:04 UTC 2018
On 12/11/18 12:10 PM, Erik Österlund wrote:
> In VtableStubs::find_stub we first perform a lookup in the table to
> check for already created stubs under the VtableStubs_lock, then if not
> found we create a new stub without the lock held, and then insert it
> under the VtableStubs_lock without checking for entries inserted between
> the lookup and insertion.
> If the VtableStubs_lock is to protect the table (which is the
> intention), the lock should not be unlocked before lookup and insert.
Looks good to me.
More information about the hotspot-compiler-dev