[aarch64-port-dev ] RFR: JDK-8196064: AArch64: Merging ld/st into ldp/stp in macro-assembler
zhongwei.yao at linaro.org
Fri Feb 23 02:26:02 UTC 2018
Is this patch ok for merging?
If yes, Felix, could you help me merge it? Thanks a lot!
2018年2月22日 下午8:35，"Felix Yang" <felix.yang at linaro.org>写道：
Yes, you are right. The comments in the function reminds me.
On 21 February 2018 at 10:37, Zhongwei Yao <zhongwei.yao at linaro.org> wrote:
> Hi, Felix,
> Thank for your review!
> The change in zero_memory is necessary. Otherwise, the generated
> multiple str instructions will be merged into stp, which breaks the
> assumption of zero_memory's algorithm: each store instruction stores
> one word. Check the generated assembly of zero_memory function may
> help understand it better.
> On 17 February 2018 at 09:15, Felix Yang <felix.yang at linaro.org> wrote:
> > Hi,
> > Overall, the patch looks good to me.
> > One question: is the change in MacroAssembler::zero_memory necessary?
> > Thanks,
> > Felix
> > On 12 February 2018 at 18:03, Zhongwei Yao <zhongwei.yao at linaro.org>
> >> I see. Thanks.
> >> On 12 February 2018 at 17:51, Andrew Haley <aph at redhat.com> wrote:
> >> > On 11/02/18 02:56, Zhongwei Yao wrote:
> >> >> And I forgot to mention that since this patch touches some shared
> >> >> at hotspot/share/asm/codeBuffer.hpp, do I need a sponsor from
> >> >
> >> > In theory, no. The submission forest should do that job. I'll have a
> >> > try.
> >> >
> >> > --
> >> > Andrew Haley
> >> > Java Platform Lead Engineer
> >> > Red Hat UK Ltd. <https://www.redhat.com>
> >> > EAC8 43EB D3EF DB98 CC77 2FAD A5CD 6035 332F A671
> >> --
> >> Best regards,
> >> Zhongwei
> Best regards,
-------------- next part --------------
An HTML attachment was scrubbed...
More information about the hotspot-compiler-dev