RFR JDK-8194642: Improve error reporting in hs_error file for JDK8

David Holmes david.holmes at oracle.com
Mon Feb 26 05:29:55 UTC 2018

Hi Fairoz,

On 26/02/2018 2:10 PM, Fairoz Matte wrote:
> Hi All,
> Kindly review the small enhancement for 8u-dev, which is a mini backport of JDK-8136421, only things related to hs_error file improvements were considered.
> JBS - https://bugs.openjdk.java.net/browse/JDK-8194642
> Webrev - http://cr.openjdk.java.net/~fmatte/8194642/webrev.00/
> Reference
> JDK9 bug - https://bugs.openjdk.java.net/browse/JDK-8136421
> JDK9 changeset -  http://hg.openjdk.java.net/jdk9/jdk9/hotspot/rev/a41fe5ffa839#l381.1 and http://hg.openjdk.java.net/jdk9/jdk9/hotspot/rev/a41fe5ffa839#l401.1


The backport of the OOM reason changes seems quite reasonable.


It is not at all clear to me that simply doing "return NULL" is 
sufficient to achieve the desired goal here. Given all the other changes 
that were done in 8136421 I can't tell if something else may be needed 
for this part - which seems to be the key change you are after. I have 
to wonder why we did not already just "return NULL" if regular error 
reporting can already handle it?

> Testing: JPRT no issues found

What crash testing have you done to verify that the new error reports 
are as expected?


> Thanks,
> Fairoz

More information about the hotspot-compiler-dev mailing list