RFR 11 (S): 8195069: LogCompilation - add basic unit tests
eric.caspole at oracle.com
Thu Jan 18 23:13:51 UTC 2018
On 01/18/2018 06:02 PM, Vladimir Kozlov wrote:
> Hi Eric,
> Need more explanation about this. How you run the test?
The tests automatically run in the maven build process with "mvn clean
install" for example. It is by convention where the tests are in
> Do you test LogCompilation functionality in JVM or the tool which parse
> log file?
> If you want to test the tool why use pre-generated log files? You should
> generate them with latest JVM.
Ideally we can generate the LogCompilation output on the fly in the
build then analyze it, but just to set up the basic framework for future
progress, here I just have it reading these small static files, to make
sure there are no reportInternalError()'s happening like with JDK-8195064.
So this is a very primitive starter set for testing.
> On 1/18/18 2:39 PM, Eric Caspole wrote:
>> Hi everybody,
>> Could I have reviews for this change which adds very simple junits and
>> more importantly the structure to add better ones later, to help
>> prevent bit rot in LogCompilation.
>> JBS: https://bugs.openjdk.java.net/browse/JDK-8195069
>> Webrev: http://cr.openjdk.java.net/~ecaspole/JDK-8195069/webrev/
More information about the hotspot-compiler-dev