RFR JDK-8194642: Improve error reporting in hs_error file for JDK8
fairoz.matte at oracle.com
Mon Mar 5 04:29:05 UTC 2018
Thanks for the review.
Restricting this issue only to improve OOM related error messaging. Fatal error reporting can be taken separately as there is already couple of other fatal errors need to be handled in similar way.
Changed the description and scope of the work.
Kindly review the webrev.01 having OOM related changes.
JBS - https://bugs.openjdk.java.net/browse/JDK-8194642
> -----Original Message-----
> From: David Holmes
> Sent: Monday, February 26, 2018 11:00 AM
> To: Fairoz Matte <fairoz.matte at oracle.com>; hotspot-compiler-
> dev at openjdk.java.net; hotspot-runtime-dev at openjdk.java.net
> Subject: Re: RFR JDK-8194642: Improve error reporting in hs_error file for
> Hi Fairoz,
> On 26/02/2018 2:10 PM, Fairoz Matte wrote:
> > Hi All,
> > Kindly review the small enhancement for 8u-dev, which is a mini backport
> of JDK-8136421, only things related to hs_error file improvements were
> > JBS - https://bugs.openjdk.java.net/browse/JDK-8194642
> > Webrev - http://cr.openjdk.java.net/~fmatte/8194642/webrev.00/
> > Reference
> > JDK9 bug - https://bugs.openjdk.java.net/browse/JDK-8136421
> > JDK9 changeset -
> > http://hg.openjdk.java.net/jdk9/jdk9/hotspot/rev/a41fe5ffa839#l381.1
> > and
> > http://hg.openjdk.java.net/jdk9/jdk9/hotspot/rev/a41fe5ffa839#l401.1
> The backport of the OOM reason changes seems quite reasonable.
> It is not at all clear to me that simply doing "return NULL" is sufficient to
> achieve the desired goal here. Given all the other changes that were done in
> 8136421 I can't tell if something else may be needed for this part - which
> seems to be the key change you are after. I have to wonder why we did not
> already just "return NULL" if regular error reporting can already handle it?
> > Testing: JPRT no issues found
> What crash testing have you done to verify that the new error reports are as
> > Thanks,
> > Fairoz
More information about the hotspot-compiler-dev