RFR 8213203: [JVMCI] adopt formatting changes from jvmci 8

Vladimir Kozlov vladimir.kozlov at oracle.com
Fri Nov 2 00:10:30 UTC 2018

After offline discussion and looking on old review I found that original complains were about overview.html files which 
were in some jvmci and graal directory. package-info.java files are fine and present in other JDK directories.

I am fine with these changes.


On 11/1/18 4:10 PM, Tom Rodriguez wrote:
> Vladimir Kozlov wrote on 11/1/18 1:51 PM:
>> Looks good except new package-info.java files. I don't think we need them in JDK. One time ago we removed them all.
>> I see we still have 2 files in JVMCI and 10  in Graal sources. We should remove them.
> I'll go ahead and remove them.  We use them in graal-jvmci-8 to drive our sigtest logic which validates the public API 
> we expose and I figured it wouldn't hurt to bring them across.
> tom
>> Thanks,
>> Vladimir
>> On 11/1/18 1:21 PM, Tom Rodriguez wrote:
>>> http://cr.openjdk.java.net/~never/8213203/webrev
>>> https://bugs.openjdk.java.net/browse/JDK-8213203
>>> This brings over primarily formatting changes from graal-jvmci-8 to partially synchronize the sources.  Mostly these 
>>> are documentation improvements and style cleanups.  There are also some changes to reduce the visibility of 
>>> non-public classes in the public API. Testing is underway.
>>> tom

More information about the hotspot-compiler-dev mailing list