RFR: 8213795: Force explicit null check on patching placeholder offset

Roman Kennke rkennke at redhat.com
Tue Nov 13 15:16:55 UTC 2018

With current logic after JDK-8213199, we allow implicit null-checks in
the offset range [-cell_header_size;vm_page_size). When using
Shenandoah, cell_header_size is -8, so we allow [-8;vm_page_size).
Unfortunately, this disables explicit null-checks on -1 which is used as
placeholder for offsets to be patched in C1. This results in weird
asserts later and may actually crash if offset is outside of legal range
for implicit null-checks. We need to force explicit null checks on -1.


Testing: tier1 and Shenandoah testing

Can I please get a review?


-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: OpenPGP digital signature
URL: <http://mail.openjdk.java.net/pipermail/hotspot-compiler-dev/attachments/20181113/e0442226/signature.asc>

More information about the hotspot-compiler-dev mailing list