RFR(trivial): 8230037: Confused MetaData dumped by PrintOptoAssembly

Jie Fu fujie at loongson.cn
Fri Aug 23 01:57:19 UTC 2019

Hi Vladimir,

Thanks for your review and valuable comments.
Please see comments inline.

On 2019/8/23 上午12:16, Vladimir Kozlov wrote:
> The output is under ttyLocker so it should be one block. 
Yes. It's in the same block with OptoAssembly.
Although they are in the same block, the MetaData is always older than 
the OptoAssembly.
The MetaData belongs to the last normal compilation of the method, not 
the current OptoAssembly.

> I see that there is mix of tty and xtty streams in code. May be that 
> is the reason it is not together. If we use xtty it should be passed 
> to print_metadata() too. Please, investigate more.
I didn't notice this problem before. Will do. Thanks.

> Instead of "Last Normal Compilation" I would print Compile_id.
Good suggestion. Thanks.

Thanks a lot.
Best regards,

> Thanks,
> Vladimir
> On 8/22/19 4:50 AM, Jie Fu wrote:
>> Hi all,
>> JBS:    https://bugs.openjdk.java.net/browse/JDK-8230037
>> Webrev: http://cr.openjdk.java.net/~jiefu/8230037/webrev.00/
>> People may get confused with the 'MetaData' dumped by PrintOptoAssembly.
>> For detailed info, please see the JBS.
>> It might be better to make it more clear.
>> Testing:
>>   - make test TEST="test/hotspot/jtreg:tier1" CONF=fastdebug on 
>> Linux/x64
>>   - make test TEST="tier1"                    CONF=release   on 
>> Linux/x64
>> Thanks a lot.
>> Best regards,
>> Jie

More information about the hotspot-compiler-dev mailing list