[aarch64-port-dev ] RFR: 8218748: AARCH64: String::compareTo intrinsic documentation and maintenance improvement

Dmitry Samersoff dms at samersoff.net
Sun May 19 15:42:11 UTC 2019


The changes looks good to me.


On 25.02.2019 19:52, Dmitrij Pochepko wrote:
> Hi Andrew, Pengfei,
> I created webrev.02 with all your suggestions implemented:
> webrev: http://cr.openjdk.java.net/~dpochepk/8218748/webrev.02/
> - comments are now both in separate section and inlined into code.
> - documentation mismatch mentioned by Pengfei is fixed:
> -- SHORT_LAST_INIT label name misprint changed to correct SHORT_LAST
> -- SHORT_LOOP_TAIL block now merged with last instruction. Documentation
> is updated respectively
> - minor other changes to layout and wording
> Newly developed tests were run as sanity and they passed.
> Thanks,
> Dmitrij
> On 22/02/2019 6:42 PM, Andrew Haley wrote:
>> On 2/22/19 10:31 AM, Pengfei Li (Arm Technology China) wrote:
>>> So personally, I still prefer to inline the comments with the
>>> original code block to avoid this kind of inconsistencies. And it
>>> makes us easier to review or maintain the code together with the
>>> doc, as we don't need to scroll back and force. I don't know the
>>> benefit of making the code documentation as a separate part. What's
>>> your opinion, Andrew Haley?
>> I agree with you. There's no harm having both inline and separate.

More information about the hotspot-compiler-dev mailing list