RFR(trivial): JDK-8224568: minimal and zero build fails after JDK-8213084

Aleksey Shipilev shade at redhat.com
Wed May 22 14:19:06 UTC 2019

On 5/22/19 10:41 AM, Ao Qi wrote:
> JBS:
> https://bugs.openjdk.java.net/browse/JDK-8224568
> Webrev:
> http://cr.openjdk.java.net/~aoqi/8224568/webrev.00/

Header addition looks trivial and good.

Rewiring platform-specific ifdefs raises a lot of questions (mostly to the original patch): since we
are always defining to the same value, why do we even have platform-specific defines there? Also,
that means that new platform would break without new platform-specific block there. I think we are
better off just dropping the platform-specific defines and just unconditionally set _show_bytes=false.

Lutz, please advise here.


-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: OpenPGP digital signature
URL: <https://mail.openjdk.java.net/pipermail/hotspot-compiler-dev/attachments/20190522/be01ae6b/signature.asc>

More information about the hotspot-compiler-dev mailing list