deoptimization.cpp Events::log / Events::log_deopt_message - was : RE: RFR: 8224221: add memprotect calls to event log
matthias.baesken at sap.com
Thu May 23 11:16:43 UTC 2019
Hello, could please someone comment on the Events::log / Events::log_deopt_message calls in deoptimization.cpp , should they better all
Go to the depot log ( Events::log_deopt_message ) ?
Best regards, Matthias
> > Btw when looking into the other already present Events::log* calls I wondered about this :
> > In deoptimization.cpp , there are 3 calls to Events:log, like
> > Events::log(thread, "DEOPT UNPACKING pc=" INTPTR_FORMAT " sp="
> INTPTR_FORMAT " mode %d",
> > p2i(stub_frame.pc()), p2i(stub_frame.sp()), exec_mode);
> > But just one Events::log_deopt_message
> > Events::log_deopt_message(thread, "Uncommon trap: reason=%s
> action=%s pc=" INTPTR_FORMAT " method=%s @ %d %s",
> > trap_reason_name(reason), trap_action_name(action),
> > trap_method->name_and_sig_as_C_string(), trap_bci, nm-
> > I think all 4 messages should go to the separate deoptimization - log and use Events::log_deopt_message.
> > Or is there a special intentation why some go into the depot-log (Events::log_deopt_message ) and some into the general events log (Events::log) ?
> I have no idea sorry. Best to open an issue and/or discuss this with the
> compiler folk.
More information about the hotspot-compiler-dev