[8u-dev, ppc] RFR for (almost clean) backport of 8185696: PPC64: Improve VSR support to use up to 64 registers

Andrew John Hughes gnu.andrew at redhat.com
Mon May 27 16:31:35 UTC 2019

On 27/05/2019 10:06, Kazunori Ogata wrote:
> Hi,
> I'm requesting backport of 8185696: PPC64: Improve VSR support to use up 
> to 64 registers to jdk8u-dev.  This patch can be applied almost cleanly, 
> but one chunk failed (other than a copyright year conflict) because the 
> definition of MTVSRWA_OPCODE is missing in 
> src/cpu/ppc/vm/assembler_ppc.hpp.
> MTVSRWA_OPCODE was added in 8144019: PPC64 C1: Introduce Client Compiler 
> [1], which added tiered compilation feature in JDK9.  Since JDK8 does not 
> support tiered compilation, we cannot apply this change set.
> So I manually applied the failed chunk by skipping the MTVSRWA_OPCODE 
> definition because no code in this changeset and other changesets I'm 
> going to backport uses this opcode.  I'll leave it to the future backport 
> that really needs this opcode.
> Is this fix acceptable for backport request?  If there is no objection in 
> a few days, I'll go forward to add jdk8u-fix-request tag in the original 
> bug report.  I verified I can build both fastdebug and release version, 
> and no degradation in jtreg.
> Original bug report:
> https://bugs.openjdk.java.net/browse/JDK-8185969
> Webrev:
> http://cr.openjdk.java.net/~horii/jdk8u_aes_be/8185969/webrev.02/
> Refs:
> [1] https://bugs.openjdk.java.net/browse/JDK-8144019

This mostly looks ok, but why is the copyright header updated to 2019
for assembler_ppc.hpp, but not register_ppc.hpp and register_ppc.cpp?

Andrew :)

Senior Free Java Software Engineer
Red Hat, Inc. (http://www.redhat.com)

PGP Key: ed25519/0xCFDA0F9B35964222 (hkp://keys.gnupg.net)
Fingerprint = 5132 579D D154 0ED2 3E04  C5A0 CFDA 0F9B 3596 4222

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 228 bytes
Desc: OpenPGP digital signature
URL: <https://mail.openjdk.java.net/pipermail/hotspot-compiler-dev/attachments/20190527/2c32cad4/signature.asc>

More information about the hotspot-compiler-dev mailing list