RFR(T/S) : 8224945 : googlemock update breaks the build of arm32

Volker Simonis volker.simonis at gmail.com
Wed May 29 08:23:21 UTC 2019

Hi Igor,

thanks for considering ppc in your fix as well.

Your changes are definitely required on ppc but I'm not sure if that's
enough. I'm currently running a build to verify that. I'll let you
know in an hour or so.

Best regards,

On Wed, May 29, 2019 at 9:11 AM Igor Ignatyev <igor.ignatyev at oracle.com> wrote:
> http://cr.openjdk.java.net/~iignatyev//8224945/webrev.00/index.html
> > 10 lines changed: 10 ins; 0 del; 0 mod;
> Hi all,
> could you please review this small and trivial patch which undefines R, F1 and F2 macros in unittest.hpp so they won't conflict w/ typenames used in gmock?
> testing: extensive build testing (which found JDK-8224949 -- an unrelated breakage on linux-x86)
> webrev: http://cr.openjdk.java.net/~iignatyev//8224945/webrev.00/index.html
> JBS: https://bugs.openjdk.java.net/browse/JDK-8224945
> Thanks,
> -- Igor

More information about the hotspot-compiler-dev mailing list