RFR(T/S) : 8224945 : googlemock update breaks the build of arm32
igor.ignatyev at oracle.com
Wed May 29 18:55:15 UTC 2019
thanks for review! pushed.
> On May 29, 2019, at 1:54 AM, Volker Simonis <volker.simonis at gmail.com> wrote:
> Looks good! With your change I can successfully build ppc64 platfroms again!
> Thanks and thumbs up from me!
> On Wed, May 29, 2019 at 10:23 AM Volker Simonis
> <volker.simonis at gmail.com> wrote:
>> Hi Igor,
>> thanks for considering ppc in your fix as well.
>> Your changes are definitely required on ppc but I'm not sure if that's
>> enough. I'm currently running a build to verify that. I'll let you
>> know in an hour or so.
>> Best regards,
>> On Wed, May 29, 2019 at 9:11 AM Igor Ignatyev <igor.ignatyev at oracle.com> wrote:
>>>> 10 lines changed: 10 ins; 0 del; 0 mod;
>>> Hi all,
>>> could you please review this small and trivial patch which undefines R, F1 and F2 macros in unittest.hpp so they won't conflict w/ typenames used in gmock?
>>> testing: extensive build testing (which found JDK-8224949 -- an unrelated breakage on linux-x86)
>>> webrev: http://cr.openjdk.java.net/~iignatyev//8224945/webrev.00/index.html
>>> JBS: https://bugs.openjdk.java.net/browse/JDK-8224945
>>> -- Igor
More information about the hotspot-compiler-dev