<div class="gmail_quote">On Fri, Jul 6, 2012 at 11:34 PM, Vladimir Kozlov <span dir="ltr"><<a href="mailto:vladimir.kozlov@oracle.com" target="_blank">vladimir.kozlov@oracle.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<div class="im">> I'm a little bit worried about this part after seeing your fix for 7181658. Do you think it's safe to use uncast()<br>
<br></div>
It was another Vladimir (Ivanov) who fixed 7181658 :-)<div class="im"><br></div></blockquote><div>Oops, I'm sorry guys!</div><div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<div class="im">
<br>
> this way, or should we use eqv_uncast() for comparison at the use sites of StringConcat::argument_uncast(<u></u>)?<br>
<br></div>
I think using uncast() in argument_uncast() is safe, it is used only in related code. The first time argument_uncast() is called to find a Proj node from SB.toString() call. Then that Proj node passed to merge() method as 'arg'. And in the merge() method argument_uncast() is called second time to compare with that passed 'arg'.<br>
<br></blockquote><div>Alright. I just needed someone else to confirm it.</div><div><br></div><div>Thanks,</div><div>Kris</div><div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
Thanks,<br>
Vladimir</blockquote></div>