<html>
  <head>
    <meta content="text/html; charset=UTF-8" http-equiv="Content-Type">
  </head>
  <body text="#000000" bgcolor="#FFFFFF">
    <div class="moz-cite-prefix">Already done.<br>
      <br>
      Best,<br>
      Albert<br>
      <br>
      On 28.09.2013 00:40, Christian Thalinger wrote:<br>
    </div>
    <blockquote
      cite="mid:B2721492-028B-4E83-9318-E63F1D1AFE89@oracle.com"
      type="cite">
      <meta http-equiv="Content-Type" content="text/html; charset=UTF-8">
      I've already pointed this out to Albert but before we can accept
      your contributions you need to sign the OCA.  See:
      <div><br>
      </div>
      <div><a moz-do-not-send="true"
          href="http://openjdk.java.net/contribute/">http://openjdk.java.net/contribute/</a></div>
      <div><br>
        <div>
          <div>On Sep 27, 2013, at 7:39 AM, Tobias Hartmann &lt;<a
              moz-do-not-send="true"
              href="mailto:tobi.hartmann@gmail.com">tobi.hartmann@gmail.com</a>&gt;
            wrote:</div>
          <br class="Apple-interchange-newline">
          <blockquote type="cite">
            <div dir="ltr">Chris, Vladimir, thank you for your reviews. 
              <div>I followed your suggestions and added other useful
                statistics. The output now looks like this:
                <div><br>
                </div>
                <div>
                  <div>Method flushing statistics:</div>
                  <div>
                      Total sweep time: 152.649ms</div>
                  <div>  Peak sweep time: 15.979ms</div>
                  <div>  Peak sweep fraction time: 3.209ms</div>
                  <div>  Total number of stack traversals: 25</div>
                  <div>  Total number of flushed methods: 1320</div>
                  <div>
                      Total size of flushed methods: 7188Kb</div>
                </div>
                <div><br>
                </div>
                <div>I did not include the other values, because as
                  Vladimir already said, they are removed by <span
                    style="font-family:arial,sans-serif;font-size:13px">8020151.</span></div>
                <div><br>
                </div>
                <div>Here is the new webrev:</div>
                <div><a moz-do-not-send="true"
                    href="http://cr.openjdk.java.net/%7Eanoll/8025277/webrev.01/"
                    target="_blank">http://cr.openjdk.java.net/~anoll/8025277/webrev.01/</a><br>
                </div>
                <div><br>
                </div>
                <div>Thanks again for your review.</div>
                <div><br>
                </div>
                <div>Regards,</div>
                <div>Tobias</div>
                <div><br>
                </div>
                <div><br>
                </div>
              </div>
            </div>
            <div class="gmail_extra"><br>
              <br>
              <div class="gmail_quote">2013/9/27 Vladimir Kozlov <span
                  dir="ltr">&lt;<a moz-do-not-send="true"
                    href="mailto:vladimir.kozlov@oracle.com"
                    target="_blank">vladimir.kozlov@oracle.com</a>&gt;</span><br>
                <blockquote class="gmail_quote" style="margin:0 0 0
                  .8ex;border-left:1px #ccc solid;padding-left:1ex">I
                  agree with Chris, we are collecting those counters
                  anyway. I also like Chris's idea about collecting
                  freed sizes. Note, some counters will be removed by
                  8020151 changes:<br>
                  <br>
                  <a moz-do-not-send="true"
                    href="http://cr.openjdk.java.net/%7Eanoll/8020151/webrev.03/"
                    target="_blank">http://cr.openjdk.java.net/~anoll/8020151/webrev.03/</a><br>
                  <br>
                  Thanks,<br>
                  Vladimir
                  <div class="im"><br>
                    <br>
                    On 9/26/13 2:13 PM, Chris Plummer wrote:<br>
                  </div>
                  <blockquote class="gmail_quote" style="margin:0 0 0
                    .8ex;border-left:1px #ccc solid;padding-left:1ex">
                    <div class="im">
                      Hi Tobias,<br>
                      <br>
                      The one comment I would have is that the
                      statistics you produce are all<br>
                      timing related, but the option name implies you
                      would get a bit more<br>
                      than this. For example, maybe something like a
                      count of the number of<br>
                      methods flushed (and maybe total size). So I would
                      suggest either rename<br>
                      to PrintMethodFlushingTimingStatistics (and also
                      rename the print<br>
                      method), or add some other useful statistics to
                      the output. Probably all<br>
                      the counters located below the " Stat counters"
                      comment are good candidates.<br>
                      <br>
                      best regards,<br>
                      <br>
                      Chris<br>
                      <br>
                      On 9/25/13 12:20 AM, Tobias Hartmann wrote:<br>
                    </div>
                    <blockquote class="gmail_quote" style="margin:0 0 0
                      .8ex;border-left:1px #ccc solid;padding-left:1ex">
                      <div class="im">
                        Hi,<br>
                        <br>
                        Please review the following small patch.<br>
                        <br>
                        bug:�<a moz-do-not-send="true"
                          href="https://bugs.openjdk.java.net/browse/JDK-8025277"
                          target="_blank">https://bugs.openjdk.java.net/browse/JDK-8025277</a><br>
                        webrev:�<a moz-do-not-send="true"
                          href="http://cr.openjdk.java.net/%7Eanoll/8025277/webrev.00/"
                          target="_blank">http://cr.openjdk.java.net/~anoll/8025277/webrev.00/</a><br>
                      </div>
                      &lt;<a moz-do-not-send="true"
                        href="http://cr.openjdk.java.net/%7Eanoll/8025277/webrev.00/"
                        target="_blank">http://cr.openjdk.java.net/%7Eanoll/8025277/webrev.00/</a>&gt;
                      <div class="im"><br>
                        <br>
                        I added the diagnostic VM option�PrintMethodFlushingStatistics
                        to<br>
                        print statistics about the NMethodSweeper (sweep
                        times) on exit. This<br>
                        is useful to determine performance bottlenecks
                        of applications that<br>
                        heavily compile code (e.g. nashorn).<br>
                        <br>
                        Thanks in advance!<br>
                        <br>
                        Best regards,<br>
                        Tobias<br>
                        <br>
                        <br>
                        By the way, I'm Tobias Hartmann, a student from
                        Switzerland currently<br>
                        working on my Master Thesis "Code Cache
                        Optimizations for Dynamically<br>
                        Compiled Languages" on supervision of Albert
                        Noll.<br>
                        <br>
                        <br>
                      </div>
                    </blockquote>
                    <br>
                  </blockquote>
                </blockquote>
              </div>
              <br>
            </div>
          </blockquote>
        </div>
        <br>
      </div>
    </blockquote>
    <br>
  </body>
</html>