<html>
  <head>
    <meta content="text/html; charset=windows-1252"
      http-equiv="Content-Type">
  </head>
  <body bgcolor="#FFFFFF" text="#000000">
    <div class="moz-cite-prefix">Hi Chris,<br>
      <br>
      thanks for looking at this. I'll fix the typos before pushing.<br>
      <br>
      Best,<br>
      Albert<br>
      <br>
      On 24.10.2013 18:12, Christian Thalinger wrote:<br>
    </div>
    <blockquote
      cite="mid:418342F0-599F-4ADB-A758-647F9FBD3CDC@oracle.com"
      type="cite">
      <meta http-equiv="Content-Type" content="text/html;
        charset=windows-1252">
      <pre><b style="font-family: Times; font-size: medium; white-space: normal;">src/share/vm/runtime/sharedRuntime.cpp:</b></pre>
      <pre><font color="blue"><b>+       // The compilation falls outside the allowed range. Note that this can only happen in debug</b></font>
<font color="blue"><b>+       // build if the cIStart(OSR) and CIStop(OSR) flags at are specified. Since currently this wrapper</b></font></pre>
      <div>
        <div>Typo:  CIStart.  Also, should this be:  “flags are”?</div>
        <div><br>
        </div>
        <div>Otherwise this looks good.</div>
        <div><br>
        </div>
        <div>On Oct 24, 2013, at 1:56 AM, Albert Noll &lt;<a
            moz-do-not-send="true" href="mailto:albert.noll@oracle.com">albert.noll@oracle.com</a>&gt;
          wrote:</div>
        <br class="Apple-interchange-newline">
        <blockquote type="cite">
          <meta content="text/html; charset=windows-1252"
            http-equiv="Content-Type">
          <div bgcolor="#FFFFFF" text="#000000">
            <div class="moz-cite-prefix">Here is the updated webrev:<br>
              <br>
              <meta http-equiv="content-type" content="text/html;
                charset=windows-1252">
              <a moz-do-not-send="true"
                href="http://cr.openjdk.java.net/%7Eanoll/8022494/webrev.04/">http://cr.openjdk.java.net/~anoll/8022494/webrev.04/</a><br>
              <br>
              Best,<br>
              Albert<br>
              <br>
              On 24.10.2013 10:21, Albert Noll wrote:<br>
            </div>
            <blockquote cite="mid:5268D875.5030506@oracle.com"
              type="cite">Hi Aleksey, <br>
              <br>
              thanks for looking at this. <br>
              <br>
              On 24.10.2013 10:15, Aleksey Shipilev wrote: <br>
              <blockquote type="cite">On 10/24/2013 12:01 PM, Albert
                Noll wrote: <br>
                <blockquote type="cite">Here is the updated webrev: <br>
                  <a moz-do-not-send="true"
                    class="moz-txt-link-freetext"
                    href="http://cr.openjdk.java.net/%7Eanoll/8022494/webrev.03/">http://cr.openjdk.java.net/~anoll/8022494/webrev.03/</a>
                  <br>
                </blockquote>
                Nice to see the locking gone. <br>
                <br>
                compileBroker.cpp: <br>
                   * Is that considered correct that OSR and normal
                compilations are <br>
                marked differently when running in debug mode, but not
                in release? I <br>
                understand the comment before assign_compile_id, so this
                is more of the <br>
                philosophical question. <br>
              </blockquote>
              Compilation IDs are only different if -XX:CICountOSR is
              set, which is <br>
              defaulted to false. <br>
              <blockquote type="cite">sharedRuntime.cpp: <br>
                   * Why do you need "2653   return;" in the method
                tail? <br>
              </blockquote>
              Thanks for spotting this. I missed it during the cleanup.
              <br>
              <br>
              Best, <br>
              Albert <br>
              <blockquote type="cite">Thanks, <br>
                -Aleksey. <br>
              </blockquote>
              <br>
            </blockquote>
            <br>
          </div>
        </blockquote>
      </div>
      <br>
    </blockquote>
    <br>
  </body>
</html>