<html>
  <head>
    <meta content="text/html; charset=ISO-8859-1"
      http-equiv="Content-Type">
  </head>
  <body bgcolor="#FFFFFF" text="#000000">
    That looks good to me (not a Reviewer).<br>
    <br>
    Best,<br>
    Albert<br>
    <br>
    <div class="moz-cite-prefix">On 06/24/2014 07:51 AM, Tobias Hartmann
      wrote:<br>
    </div>
    <blockquote cite="mid:53A911FC.7060408@oracle.com" type="cite">
      <meta content="text/html; charset=ISO-8859-1"
        http-equiv="Content-Type">
      Thank you, Igor.<br>
      <br>
      Best,<br>
      Tobias<br>
      <br>
      <div class="moz-cite-prefix">On 21.06.2014 05:57, Igor Veresov
        wrote:<br>
      </div>
      <blockquote
        cite="mid:43D76AC7-6B16-4491-ADE2-BDDFF42D0056@oracle.com"
        type="cite">
        <meta http-equiv="Content-Type" content="text/html;
          charset=ISO-8859-1">
        Look good.
        <div><br>
        </div>
        <div>igor</div>
        <div><br>
          <div style="">
            <div>On Jun 18, 2014, at 6:31 AM, Tobias Hartmann <<a
                moz-do-not-send="true"
                href="mailto:tobias.hartmann@oracle.com">tobias.hartmann@oracle.com</a>>

              wrote:</div>
            <br class="Apple-interchange-newline">
            <blockquote type="cite">
              <meta http-equiv="content-type" content="text/html;
                charset=ISO-8859-1">
              <div bgcolor="#FFFFFF" text="#000000"> Hi,<br>
                <br>
                please review the following patch for 8033332.<br>
                <br>
                <b>Problem</b><br>
                The 32 bit version of
                TemplateInterpreterGenerator::generate_result_handler_for(..)
                does not handle the basic types T_LONG and T_VOID.
                Currently it does not fail because
                AbstractInterpreter::BasicType_as_index(..) returns the
                same index (4) for T_INT, T_LONG and T_VOID and
                therefore TemplateInterpreterGenerator::generate_all(..)
                invokes the method only once for T_INT. This can cause
                problems if the ordering of types changes.<br>
                <br>
                <b>Solution</b><br>
                Add missing case statements for T_LONG and T_VOID to
                generate_result_handler_for(..).<br>
                <br>
                <b>Testing</b><br>
                JPRT<br>
                <br>
                Bug: <a moz-do-not-send="true"
                  class="moz-txt-link-freetext"
                  href="https://bugs.openjdk.java.net/browse/JDK-8033332">https://bugs.openjdk.java.net/browse/JDK-8033332</a><br>
                Webrev: <a moz-do-not-send="true"
                  class="moz-txt-link-freetext"
                  href="http://cr.openjdk.java.net/%7Ethartmann/8033332/webrev.00/">http://cr.openjdk.java.net/~thartmann/8033332/webrev.00/</a><br>
                <br>
                Thanks,<br>
                Tobias<br>
              </div>
            </blockquote>
          </div>
          <br>
        </div>
      </blockquote>
      <br>
    </blockquote>
    <br>
  </body>
</html>