<html>
  <head>
    <meta content="text/html; charset=utf-8" http-equiv="Content-Type">
  </head>
  <body text="#000000" bgcolor="#FFFFFF">
    I also updated the -XX:NonMethodCodeHeapSize VM option and the
    corresponding CodeBlobType.<br>
    <br>
    New webrev:<br>
    <a class="moz-txt-link-freetext" href="http://cr.openjdk.java.net/~thartmann/8059468/webrev.02/">http://cr.openjdk.java.net/~thartmann/8059468/webrev.02/</a><br>
    <br>
    Thanks,<br>
    Tobias<br>
    <br>
    <div class="moz-cite-prefix">On 30.09.2014 15:02, Tobias Hartmann
      wrote:<br>
    </div>
    <blockquote cite="mid:542AA9D3.10601@oracle.com" type="cite">
      <meta content="text/html; charset=utf-8" http-equiv="Content-Type">
      Hi Albert,<br>
      <br>
      thanks for the review.<br>
      <br>
      <div class="moz-cite-prefix">On 30.09.2014 14:44, Albert Noll
        wrote:<br>
      </div>
      <blockquote cite="mid:542AA5AF.3020607@oracle.com" type="cite">
        <meta content="text/html; charset=utf-8"
          http-equiv="Content-Type">
        Looks good to me (not a reviewer).<br>
        <br>
        Minor nit (which need not be fixed): Wouldn't the naming be more
        consistent if we call the non-method heap non-nmethod heap?<br>
        <meta http-equiv="content-type" content="text/html;
          charset=utf-8">
        <pre style="color: rgb(0, 0, 0); font-style: normal; font-variant: normal; font-weight: normal; letter-spacing: normal; line-height: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; widows: auto; word-spacing: 0px; -webkit-text-stroke-width: 0px;"><b><font color="red">-</font><font color="black">   add_heap(non_method_space, "Code</font><s><font color="red"> </font></s><font color="black">Heap 'non-methods'", init_non_method_size, CodeBlobType::NonMethod);</font></b></pre>
      </blockquote>
      <br>
      Yes, I changed it as you suggested:<br>
      <br>
      <a moz-do-not-send="true" class="moz-txt-link-freetext"
        href="http://cr.openjdk.java.net/%7Ethartmann/8059468/webrev.01">http://cr.openjdk.java.net/~thartmann/8059468/webrev.01</a><br>
      <br>
      Best,<br>
      Tobias<br>
      <br>
      <blockquote cite="mid:542AA5AF.3020607@oracle.com" type="cite"> <br>
        Best,<br>
        Albert<br>
        <br>
        <div class="moz-cite-prefix">On 09/30/2014 02:34 PM, Tobias
          Hartmann wrote:<br>
        </div>
        <blockquote cite="mid:542AA349.4040104@oracle.com" type="cite">
          <meta http-equiv="content-type" content="text/html;
            charset=utf-8">
          Hi,<br>
          <br>
          please review this small patch that changes the output of
          <meta http-equiv="content-type" content="text/html;
            charset=utf-8">
          -XX:+PrintCodeCache accidentally changed by JDK-8059137
          <meta http-equiv="content-type" content="text/html;
            charset=utf-8">
          [1] from 'Code Cache' back to 'CodeCache' because some tests
          depend on the output.<br>
          <br>
          Bug: <a moz-do-not-send="true" class="moz-txt-link-freetext"
            href="https://bugs.openjdk.java.net/browse/JDK-8059468">https://bugs.openjdk.java.net/browse/JDK-8059468</a><br>
          Webrev: <a moz-do-not-send="true"
            class="moz-txt-link-freetext"
            href="http://cr.openjdk.java.net/%7Ethartmann/8059468/webrev.00/">http://cr.openjdk.java.net/~thartmann/8059468/webrev.00/</a><br>
          <br>
          Thanks,<br>
          Tobias<br>
          <br>
          [1] <a moz-do-not-send="true" class="moz-txt-link-freetext"
            href="http://hg.openjdk.java.net/jdk9/hs-comp/hotspot/rev/3af889385bcf">http://hg.openjdk.java.net/jdk9/hs-comp/hotspot/rev/3af889385bcf</a><br>
        </blockquote>
        <br>
      </blockquote>
      <br>
    </blockquote>
    <br>
  </body>
</html>