<html>
  <head>
    <meta content="text/html; charset=UTF-8" http-equiv="Content-Type">
  </head>
  <body bgcolor="#FFFFFF" text="#000000">
    Hi,<br>
    <br>
    Thank you for catching these issues.<br>
    I have a question regarding last comment: does it make any
    difference to change "reading of static member 3 times" to "copying
    into static member of another class and then read it 3 times"?<br>
    <br>
    Thanks,<br>
    Dmitrij<br>
    <blockquote cite="mid:54991962.7020806@oracle.com" type="cite">
      <meta content="text/html; charset=UTF-8" http-equiv="Content-Type">
      <div class="moz-cite-prefix">Hi Dmitry,<br>
        <br>
        <br>
        It looks good in general.<br>
        Some minor comments are below.<br>
        <br>
test/testlibrary/com/oracle/java/testlibrary/dtrace/DtraceRunner.java<br>
        <br>
        <meta http-equiv="content-type" content="text/html;
          charset=UTF-8">
        <pre>  42     public static final String PERMIT_DESCTUCTIVE_ACTIONS_DTRACE_OPTION = "w";</pre>
           A typo in the constant name: DESCTUCTIVE => DESTRUCTIVE<br>
        <br>
        <br>
        test/compiler/codecache/dtrace/SegmentedCodeCacheDtraceTest.java<br>
        <br>
        <meta http-equiv="content-type" content="text/html;
          charset=UTF-8">
        <pre>  84                 DtraceRunner.PERMIT_DESCTUCTIVE_ACTIONS_DTRACE_OPTION,</pre>
           A typo in the constant name: DESCTUCTIVE => DESTRUCTIVE<br>
        <br>
        <br>
        <meta http-equiv="content-type" content="text/html;
          charset=UTF-8">
        <pre>  60     private static final String WORKER_CLASS_NAME
  61             = SegmentedCodeCacheDtraceTestWorker.class.getName();
 ...
<meta http-equiv="content-type" content="text/html; charset=UTF-8">  80         runner.runDtrace(JDKToolFinder.getTestJDKTool("java"), JAVA_OPTS,
  81                 SegmentedCodeCacheDtraceTestWorker.class.getName(), params,
  The WORKER_CLASS_NAME can be used at 81.
</pre>
        <br>
        <meta http-equiv="content-type" content="text/html;
          charset=UTF-8">
        <pre>  75         String params = SegmentedCodeCacheDtraceTestWorker.TESTED_METHODS_LIST.stream()
 ...
<meta http-equiv="content-type" content="text/html; charset=UTF-8"> 179             List<Executable> tml
 180                     = SegmentedCodeCacheDtraceTestWorker.TESTED_METHODS_LIST;
 ...
<meta http-equiv="content-type" content="text/html; charset=UTF-8"> 235             List<Executable> mlist
 236                     = SegmentedCodeCacheDtraceTestWorker.TESTED_METHODS_LIST;
   The TESTED_METHODS_LIST is used three times.
   It can be cached at the top and re-used. 
</pre>
        <br>
        Thanks,<br>
        Serguei<br>
        <br>
        <br>
           <br>
        On 12/19/14 11:03 AM, Dmitrij Pochepko wrote:<br>
      </div>
      <blockquote cite="mid:54947677.7050104@oracle.com" type="cite">Hi
        all, <br>
        <br>
        Please review changes for <a moz-do-not-send="true"
          class="moz-txt-link-freetext"
          href="https://bugs.openjdk.java.net/browse/JDK-8059625">https://bugs.openjdk.java.net/browse/JDK-8059625</a>
        -  JEP-JDK-8043304: Test task: DTrace- tests for segmented
        codecache feature <br>
        <br>
        Description: this fix introduce dtrace test, which verify that
        different combinations of available compile levels(and, in case
        compile levels allows it, different code heaps as result) 
        doesn't affect callstack shown by dtrace. There is a control
        class SegmentedCodeCacheDtraceTest.java and class for running
        via dtrace SegmentedCodeCacheDtraceTestWorker.java. A dtrace d
        script is also present (SegmentedCodeCacheDtraceTestScript.d). A
        control class is using DtraceRunner.java to run dtrace and then
        analyzing results using class
        SegmentedCodeCacheDtraceResultsAnalyzer with
        DtraceResultsAnalyzer interface. <br>
        There is also a small class CompilerUtils.java created for
        usefull common code. <br>
        <br>
        webrev: <a moz-do-not-send="true" class="moz-txt-link-freetext"
href="http://cr.openjdk.java.net/%7Eiignatyev/dpochepk/8059625/webrev.00/">http://cr.openjdk.java.net/~iignatyev/dpochepk/8059625/webrev.00/</a>
        <br>
        <br>
        Additional note: Please note that this path assumes that fix for
        JDK-8066440 - Various changes in testlibrary for JDK-8059613 is
        also applied. <br>
        <br>
        Thanks, <br>
        Dmitrij <br>
      </blockquote>
      <br>
    </blockquote>
    <br>
  </body>
</html>